Summary: | when available m3u files are updated, juk add one more entry in the left panel, instead of updating the existing one | ||
---|---|---|---|
Product: | [Applications] juk | Reporter: | Mathieu Roy <yeupou> |
Component: | general | Assignee: | Scott Wheeler <wheeler> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | mpyne |
Priority: | NOR | ||
Version: | 2.1.2 | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.8.1 |
Description
Mathieu Roy
2005-10-03 12:15:13 UTC
Does this happen whenever the .m3u changes, or at the next JuK startup? I suspect the former but I wasn't aware that JuK had that magic implemented, although it sounds like a quite possible side effect. No, it happen only at JuK startup. OK, I think I see what the issue is (five years late...). The originally saved playlists are reloaded *after* the search for m3u files. So the m3u files are loaded and make a new dynamic playlist, and then the playlists saved from the last run are loaded. This would lead to duplication with each startup. SVN commit 1275917 by mpyne: Don't load a playlist if it's already found by folder scan. The way file scanning is performed, it's possible for a playlist that is stored with a .m3u file to be found and loaded before JuK has finished loading its cached playlists. There's a few ways to fix this, but the most conservative (especially for those dealing with this bug for awhile) is to filter playlists as they are being loaded from the cache and remove any that have already been loaded. This also does not require a change to the QDataStream binary format used for saving playlists. This should fix a bug that's been open for more than five years now... by the way, anyone want to help with finding/fixing more JuK bugs? :D M +8 -0 cache.cpp M +9 -1 playlistcollection.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1275917 SVN commit 1275920 by mpyne: Backport m3u playlist fix to KDE SC 4.8.1. This backports to KDE SC 4.8.1 the fix given in r1275917 for .m3u playlists being loaded in duplicate with folder scan enabled. FIXED-IN:4.8.1 M +8 -0 cache.cpp M +1 -1 main.cpp M +9 -1 playlistcollection.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1275920 |