Bug 111301

Summary:	korganizer weekly print views (timetable and split) require user to specify start/end times
Product:	[Applications] korganizer	Reporter:	Joseph Reagle <joseph.2011>
Component:	general	Assignee:	Reinhold Kainhofer <reinhold>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed In:

Description Joseph Reagle 2005-08-22 21:40:32 UTC

Version:            (using KDE KDE 3.4.2)
Installed from:    Debian testing/unstable Packages
OS:                Linux

The default time start and end time of 00:00:00 to 00:00:00 should print all events of the day, or be changed to 00:00:00 23:59:59 or something...

Comment 1 Philippe Rigault 2005-09-06 16:05:16 UTC

The default end time is wrong. It should be 23:59:59.

As it stands currently (start=00:00:00 , end=00:00:00), printing is pretty much useless since no events are shown on printed calendars. Rather annoying.

A more helpful bug title could be:
  Wrong default times in korganizer cause printing of empty calendars.

Comment 2 Gurvan Huiban 2006-03-16 15:20:21 UTC

The problem still exists in Korganizer 3.5.

And it is rather confusing to obtain an empty calendar with the default values.

Comment 3 Bram Schoenmakers 2006-05-10 21:33:32 UTC

SVN commit 539490 by bram:

Do load and save settings when printing. This will set sane initial values, fixing bug 116893 for example.

BUG:116893
BUG:111301
BUG:126592



 M  +2 -2      interfaces/korganizer/printplugin.h  
 M  +3 -0      printing/calprinter.cpp  
 M  +6 -1      printing/calprintweekconfig_base.ui  


--- branches/KDE/3.5/kdepim/korganizer/interfaces/korganizer/printplugin.h #539489:539490
@@ -92,11 +92,11 @@
     /**
       Load complete config.
     */
-    void doLoadConfig() {}
+    virtual void doLoadConfig() {};
     /**
       Save complete config.
     */
-    void doSaveConfig() {}
+    virtual void doSaveConfig() {};
 
 
   public:
--- branches/KDE/3.5/kdepim/korganizer/printing/calprinter.cpp #539489:539490
@@ -78,6 +78,7 @@
 {
   mCalendar = calendar;
   mPrinter = printer;
+  mHelper = new CalPrintHelper( mPrinter, mCalendar, mConfig, mCoreHelper );
 
   mPrintPlugins.clear();
   mPrintPlugins.setAutoDelete( true );
@@ -95,6 +96,8 @@
     (*it)->setConfig( mConfig );
     (*it)->setCalendar( calendar );
     (*it)->setPrinter( printer );
+    (*it)->setKOrgCoreHelper( mCoreHelper );
+    (*it)->setCalPrintHelper( mHelper );
 
     (*it)->doLoadConfig();
   }
--- branches/KDE/3.5/kdepim/korganizer/printing/calprintweekconfig_base.ui #539489:539490
@@ -14,6 +14,9 @@
             <height>262</height>
         </rect>
     </property>
+    <property name="caption">
+        <string>CalPrintWeek_Base</string>
+    </property>
     <grid>
         <property name="name">
             <cstring>unnamed</cstring>
@@ -128,7 +131,7 @@
                     </property>
                     <property name="time">
                         <time>
-                            <hour>16</hour>
+                            <hour>18</hour>
                             <minute>0</minute>
                             <second>0</second>
                         </time>
@@ -275,6 +278,8 @@
         </widget>
     </grid>
 </widget>
+<customwidgets>
+</customwidgets>
 <tabstops>
     <tabstop>mFromDate</tabstop>
     <tabstop>mFromTime</tabstop>