Summary: | "x other persons in the chat" miscount | ||
---|---|---|---|
Product: | [Applications] kopete | Reporter: | min <mihnea_capraru> |
Component: | Chat Window | Assignee: | Kopete Developers <kopete-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | sven.burmeister |
Priority: | NOR | ||
Version: | 0.10.3 | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
min
2005-07-31 14:38:45 UTC
I can see this 'bug' SVN commit 488465 by granberry: Display correct number of people in chat BUG:109935 M +1 -1 chatview.cpp --- branches/KDE/3.5/kdenetwork/kopete/kopete/chatwindow/chatview.cpp #488464:488465 @@ -409,7 +409,7 @@ if( newState != Typing ) { setStatusText( i18n( "One other person in the chat", - "%n other people in the chat", m_manager->members().count() ) ); + "%n other people in the chat", m_manager->members().count() - 1 ) ); } } Is this the fix that made all other protocolls display "0 other users in chat"? Who counts the users in an IRC chat? A 0 in a chat with mostly only two people (MSN, ICQ, Jabber etc.) is far worse! If so, why did this patch get through Q/A? SVN commit 496654 by ogoffart: Revert revision 488465 cf Bug 109935 CCMAIL: matthias.granberry@gmail.com CCBUG: 109935 The problem is that now the count of others contact is wrong with all other chat than IRC M +1 -1 chatview.cpp --- branches/work/kopete/dev-0.12/kopete/kopete/chatwindow/chatview.cpp #496653:496654 @@ -409,7 +409,7 @@ if( newState != Typing ) { setStatusText( i18n( "One other person in the chat", - "%n other people in the chat", m_manager->members().count() - 1 ) ); + "%n other people in the chat", m_manager->members().count() ) ); } } SVN commit 496656 by ogoffart: Backport revert for bug 109935 CCBUG: 109935 M +1 -1 chatview.cpp --- branches/KDE/3.5/kdenetwork/kopete/kopete/chatwindow/chatview.cpp #496655:496656 @@ -409,7 +409,7 @@ if( newState != Typing ) { setStatusText( i18n( "One other person in the chat", - "%n other people in the chat", m_manager->members().count() - 1 ) ); + "%n other people in the chat", m_manager->members().count() ) ); } } The fix was incorrect. The problem is that the channel contact is counted as a contact on IRC. The solution would be to preciselly identify the channel contact to don't count it. Thanks for reverting. If there is work put into not counting the channel, maybe one could also not count bots, if this is at all possible. It's correctly counted now - Kopete and Konversation agree. |