Bug 109115

Summary:	Compile error in KDE 3.3.2 : main.cpp KWin::setMainWindow not defined
Product:	[Applications] umbrello	Reporter:	D. Anthony Robinson <anthony>
Component:	general	Assignee:	Umbrello Development Group <umbrello-devel>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Mandriva RPMs
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	Proposed patch

Description D. Anthony Robinson 2005-07-15 05:28:06 UTC

Version:           1.4.89 (from SVN) (using KDE KDE 3.3.2)
Installed from:    Mandriva RPMs
Compiler:          g++ 3.4.3 Mandrakelinux 10.2 3.4.3-7mdk
OS:                Linux

Running KDE 3.3.2 and pulling the latest sources from SVN, I get the following error when running make (useless info cut):

main.cpp: In function `int main(int, char**)':
main.cpp:67: error: `setMainWindow' is not a member of `KWin'
make[2]: *** [main.o] Error 1
make[2]: Leaving directory `/home/anthony/sandbox/kde/kdesdk/umbrello/umbrello'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/anthony/sandbox/kde/kdesdk/umbrello/umbrello'
make: *** [all-recursive] Error 1

Some research in the KDE documentation indicates that the KWin::setMainWindow() method is present since version 3.4. The comparison in line 64 of main.cpp is:

#if KDE_IS_VERSION(3,2,90)

Changing this to:

#if KDE_IS_VERSION(3,3,90)

allows compilation to complete.

Comment 1 D. Anthony Robinson 2005-07-15 05:29:58 UTC

Created attachment 11813 [details]
Proposed patch

Proposed fix. It is a one-line change, so impact should be relatively low.
However, verification that the version comparison is correct may need to be
done.

Comment 2 Oliver Kellogg 2005-07-15 07:45:59 UTC

SVN commit 434724 by okellogg: 

>From D.Anthony Robinson (anthony_AT_chinstrap.homelinux.net): 
> I searched the docs, and found that KWin::setMainWindow is "since 3.4".