Summary: | kmail composer crashes when inserting file | ||
---|---|---|---|
Product: | [Applications] kmail | Reporter: | Bjorn Helgaas <bjorn.helgaas> |
Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | crash | ||
Priority: | NOR | ||
Version: | 1.8.1 | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Bjorn Helgaas
2005-06-24 17:37:33 UTC
My .kde/share/config/kmailrc had the following line in it: recent-encodings=iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1,iso-8859-1 Removing that line makes file insertion work again. Kmail must have generated that somewhere along the line (I certainly didn't add it by hand), and it apparently causes the crash. So there are two problems here: 1) Kmail generated a recent-encodings line that is somehow bogus. 2) Kmail doesn't validate recent-encodings when reading it from kmailrc. I just want to add that I had this problem for a while too, so it's not a completely isolated occurrence. I cannot quite remember whether this was before or after I switched from Mandrake to Gentoo, but in any case, it is not just a Debian issue. SVN commit 497015 by winterz: Fix crash during a "insert file" in the composer. Patch provided by Goffredo Baroncelli and approved by Don. Thank you Goffredo! BUGS: 111383, 108063, 111713 CCMAIL: kreijack@alice.it M +1 -1 kmcomposewin.cpp --- branches/KDE/3.5/kdepim/kmail/kmcomposewin.cpp #497014:497015 @@ -2662,7 +2662,7 @@ while (urls.count() > mMaxRecentFiles) urls.erase( urls.fromLast() ); while (encodings.count() > mMaxRecentFiles) - urls.erase( encodings.fromLast() ); + encodings.erase( encodings.fromLast() ); // sanity check if (urls.count() != encodings.count()) { urls.clear(); |