Summary: | kfile_deb crashes Konqueror consistently - just hover over a .deb file with your cursor... | ||
---|---|---|---|
Product: | [Applications] kfile-plugins | Reporter: | Ana Guerrero (Debian KDE maintainers) <ana> |
Component: | general | Assignee: | David Faure <faure> |
Status: | RESOLVED FIXED | ||
Severity: | crash | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Ana Guerrero (Debian KDE maintainers)
2005-06-01 16:38:33 UTC
Sigh.. the backtrace is *exactly* the one in #104454, why do you create a new bug report? Because that bug is triggered in a different way, and you might want to know about all manifestations of the problem. Sorry, just trying to be helpful... On Wednesday 01 June 2005 16:38, Debian KDE Maintainers wrote: > Note that KDE's default mimetype setup hides the problem, since it has 2 mimetypes for .deb files, x-deb and x-debian-package. I only have kdelibs/mimetypes/application/x-deb, there is no x-debian-package. > (kpackage contains x-debian-package.desktop, which serves as a replacement). Shipping mimetypes with applications is wrong, and that would be a KDE bug; however my kpackage source directory has no such mimetype... (and 3.4 branch neither) [snip bt] Hmm, filename=0x1? The bug is higher than I thought. It's in the tarball: kdeadmin-3.4.1/kpackage/mimetypes/x-debian-package.desktop. What should happen is that that file is removed, and kdelibs' x-deb.desktop is renamed x-debian-package.desktop, and its mimetype changed accordingly. Then we just need to patch ark... SVN commit 420860 by dfaure: Don't provide your own mimetype, when kdelibs provides it already, with a different name... BUG: 106607 M +2 -2 Makefile.am M +1 -1 kpackage.desktop D mimetypes (directory) --- branches/KDE/3.4/kdeadmin/kpackage/Makefile.am #420859:420860 @@ -2,9 +2,9 @@ xdg_apps_DATA = kpackage.desktop # claim, which subdirectories you want to install -SUBDIRS = pics toolbar icon mimetypes +SUBDIRS = pics toolbar icon -bin_PROGRAMS = kpackage +bin_PROGRAMS = kpackage # Which sources should be compiled for kpackage. kpackage_SOURCES = kpackage.cpp managementWidget.cpp packageDisplay.cpp \ --- branches/KDE/3.4/kdeadmin/kpackage/kpackage.desktop #420859:420860 @@ -79,7 +79,7 @@ GenericName[zh_CN]=软件包管理器 GenericName[zh_TW]=套件管理程式 GenericName[zu]=Umphathi Wokusongwayo -MimeType=application/x-rpm;application/x-debian-package; +MimeType=application/x-rpm;application/x-deb; Exec=kpackage -caption "%c" %i %m %u Icon=kpackage Type=Application sorry, but a grep in kpackage shows that this fix is not enough : the x-debian-package mimetype is still used : kfile-plugins/deb/kfile_deb.desktop:MimeType=application/x-debian-package kfile-plugins/deb/kfile_deb.cpp: KFileMimeTypeInfo* info = addMimeTypeInfo( "application/x-debian-package" ); see my mail x-debian-package is the older, and probably correct, mimetype. What really needs to happen is for kdelibs and kdeutils (and now kdeadmin) to be patched to use it instead of x-deb. 1) I know that the kfile plugin uses x-debian-package, see my patch to #104454 to make it use x-deb instead (as part of the crash fix there) 2) I disagree that we should use x-debian-package instead of x-deb. One reason: the shared mime database at freedesktop.org uses x-deb, and for KDE4 I want to standardize on that. But I (or you :) can add a x-debian-package alias for x-deb in kdelibs if you want, so that both work. (we support aliases, using X-KDE-IsAlso) OK, that sounds reasonable. If adding an alias for x-debian-package is as simple as adding a line in x-deb.desktop, then (correct me if I'm wrong) I don't see that it could do any harm. SVN commit 421013 by dfaure: Alias for x-deb (used to be provided by kpackage, so this alias is for compatibility). BUG: 106607 M +1 -1 Makefile.am A x-debian-package.desktop trunk/KDE/kdelibs/mimetypes/application/x-debian-package.desktop#421011 --- branches/KDE/3.4/kdelibs/mimetypes/application/Makefile.am #421012:421013 @@ -34,7 +34,7 @@ x-hancomword.desktop \ x-font-bdf.desktop x-font-pcf.desktop x-font-speedo.desktop x-font-type1.desktop \ x-font-ghostscript.desktop x-font-snf.desktop x-font-ttf.desktop \ - vnd.ms-asf.desktop x-msdos-program.desktop x-deb.desktop \ + vnd.ms-asf.desktop x-msdos-program.desktop x-deb.desktop x-debian-package.desktop \ vnd.stardivision.writer.desktop vnd.stardivision.calc.desktop \ vnd.stardivision.impress.desktop \ vnd.sun.xml.impress.desktop vnd.sun.xml.writer.desktop \ We really need some standard procedure to keep track of file moves between KDE modules between releases and making a list of them for packagers. I'm very tired of finding out about these only after users complain about strangely broken updates. |