Bug 101541

Summary:	More options to select action in sequence diagram
Product:	[Applications] umbrello	Reporter:	Anton G. Alvedro <galvedro>
Component:	general	Assignee:	Umbrello Development Group <umbrello-devel>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:

Description Anton G. Alvedro 2005-03-15 11:52:45 UTC

Version:           1.3.92 (using KDE 3.2.3, compiled sources)
Compiler:          gcc version 3.3.3
OS:                Linux (i?86) release 2.2.14-5.0

Although it is straight-forward to change the message interchanged by two classes when a sync/async message is inserted in the sequence diagram, i.e. by right clicking on the arrow and going to properties, it would be handful to be able do do this by double clicking on the arrow as well.

Another possible improvement would be to get the properties popup when drawing a new arrow. You will always need to define what message is interchanged, and by doing it this way, you prevent user to draw inconsistent diagrams (with empty messages). I think this would speed up diagram drawing as well.

Comment 1 Anton G. Alvedro 2005-03-15 14:43:04 UTC

When I am referring to the properties dialog, I mean the Operations dialog.

Comment 2 Oliver Kellogg 2005-04-15 23:57:34 UTC

*** Bug 101717 has been marked as a duplicate of this bug. ***

Comment 3 Oliver Kellogg 2005-04-16 00:08:11 UTC

CVS commit by okellogg: 

mouseRelease(): Showing the operation dialog speeds up message creation.
CCBUG:101541


  M +5 -1      toolbarstatemessages.cpp   1.17


--- kdesdk/umbrello/umbrello/toolbarstatemessages.cpp  #1.16:1.17
@@ -118,8 +118,12 @@ void ToolBarStateMessages::mouseRelease(
                         m_pUMLView->connect(m_pUMLView, SIGNAL(sigColorChanged(Uml::IDType)), message, SLOT(slotColorChanged(Uml::IDType)));
 
-                        message->setActivated();
+                        message->activate();
 
                         m_pSelectedWidget = 0;
                         m_pUMLView->getMessageList().append(message);
+                        FloatingText *ft = message->getFloatingText();
+                        ft->showOpDlg();
+                        message->setTextPosition();
+                        m_pUMLView->getWidgetList().append(ft);
                 }
         }

Comment 4 Oliver Kellogg 2005-04-16 17:17:06 UTC

CVS commit by okellogg: 

BUG:101541 - onWidget():
Fix to {top,bottom}ArrowY brings on the properties dialog upon double clicking.


  M +4 -1      ChangeLog   1.75
  M +3 -3      umbrello/messagewidget.cpp   1.71


--- kdesdk/umbrello/ChangeLog  #1.74:1.75
@@ -2,8 +2,10 @@
 
 * Externalization of folders (i.e. submodel files)
-  http://bugs.kde.org/87252
 
+* Bugs fixed / wishes implemented (see http://bugs.kde.org)
+87252 
 
 Version 1.4.1 (maintenance release)
+
 Bugs fixed:
 * Crash on deleting attributes / enum literals
@@ -11,4 +13,5 @@
 * Bugs from http://bugs.kde.org :
 53376 57667 57875 95353 100290 100307 101148 103123 103133 103728
+101541
 
 Version 1.4

--- kdesdk/umbrello/umbrello/messagewidget.cpp  #1.70:1.71
@@ -266,8 +266,8 @@ bool MessageWidget::onWidget(const QPoin
         if (p.x() < getX() || p.x() > getX() + getWidth())
                 return false;
-        const int tolerance = 4;  // pixels
+        const int tolerance = 5;  // pixels
         const int pY = p.y();
-        const int topArrowY = getY();
-        const int bottomArrowY = topArrowY + getHeight();
+        const int topArrowY = getY() + 3;
+        const int bottomArrowY = getY() + getHeight() - 3;
         if (pY < topArrowY - tolerance || pY > bottomArrowY + tolerance)
                 return false;