Summary: | Crash when visiting oddcast.com page | ||
---|---|---|---|
Product: | [Applications] konqueror | Reporter: | Sean Lynch <techniq35> |
Component: | nspluginviewer | Assignee: | George Staikos <staikos> |
Status: | RESOLVED FIXED | ||
Severity: | crash | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Sean Lynch
2005-03-05 04:43:05 UTC
No crash here. Then again, I'm betting I have no plugin for this kind of media, whatever it is. Confirmed. Can't fix yet because the "obvious" fix is also probably incorrect. [KCrash handler] #7 0x40f8b000 in QDataStream::writeRawBytes (this=0x0, s=0x893e228 "location=http%3A%2F%2Fcache-a.oddcast.com%2Fccs2%2Fcache_fs%2F4%2Fc%2F4c496c14445760da4314f20a9de3aad9&voice=2&lang=1&engine=2&text=yo yo yo. how izzz you my brother. you best be gittin out my "..., len=344) at qdatastream.cpp:1148 #8 0x080595f2 in NSPluginStreamBase::process (this=0x892e480, data=@0x892e4f8, start=0) at nsplugin.cpp:1622 #9 0x08059760 in NSPluginStreamBase::pump (this=0x892e480) at nsplugin.cpp:1649 #10 0x080599fc in NSPluginStream::data (this=0x892e480, job=0x892fc88, data=@0xbfffee10) at nsplugin.cpp:1844 #11 0x08059af6 in NSPluginStream::qt_invoke (this=0x892e480, _id=2, _o=0xbfffe9e0) at qucom_p.h:312 #12 0x40cca753 in QObject::activate_signal (this=0x892fc88, clist=0x88e7408, o=0xbfffe9e0) at qobject.cpp:2357 #13 0x401a0279 in KIO::TransferJob::data (this=0x892fc88, t0=0x892fc88, t1=@0xbfffee10) at jobclasses.moc:972 CVS commit by staikos: using the url for part of the temp filename is really not smart. BUG: 100863 M +7 -4 nsplugin.cpp 1.125 --- kdebase/nsplugins/viewer/nsplugin.cpp #1.124:1.125 @@ -1552,5 +1552,5 @@ void NSPluginStreamBase::inform() // stream into temporary file (use lower() in case the // filename as an upper case X in it) - _tempFile = new KTempFile( QString::null, src.fileName().lower() ); + _tempFile = new KTempFile; _tempFile->setAutoDelete( TRUE ); _fileURL = _tempFile->name(); @@ -1619,6 +1619,7 @@ int NSPluginStreamBase::process( const Q } - if (_tempFile) + if (_tempFile) { _tempFile->dataStream()->writeRawBytes(d, sent); + } to_sent -= sent; @@ -1642,6 +1643,7 @@ bool NSPluginStreamBase::pump() // handle AS_FILE_ONLY streams if ( _onlyAsFile ) { - if ( _tempFile ) + if (_tempFile) { _tempFile->dataStream()->writeRawBytes( _queue, _queue.size() ); + } newPos = _queuePos+_queue.size(); } else { @@ -1707,6 +1709,7 @@ void NSPluginStreamBase::finish( bool er } else { // close temp file - if ( _tempFile ) + if ( _tempFile ) { _tempFile->close(); + } // destroy stream |