KDE Bug Tracking System
Home
Report New Wish or Bug
Query Existing Reports
First
Last
Prev
Next
No search results available
Search page
Bug
77100
:
avoid calling libpng if no image is present
P
roduct
:
kopete
Co
m
ponent
:
MSN Plugin
Status
:
RESOLVED
Resolution
:
FIXED
Target
:
---
Version
:
0.8.0
Pr
i
ority
:
NOR
Severity
:
normal
V
otes
:
0
Description
:
Opened:
2004-03-09 18:01
Last Changed:
2004-04-30 21:11:53
Version: 0.8.0 (using KDE 3.2 BRANCH >= 20040204, Mandrake Linux Cooker i586 - Cooker) Compiler: gcc version 3.3.2 (Mandrake Linux 10.0 3.3.2-6mdk) OS: Linux (i686) release 2.6.3-4mdk-i686-up-4GB These error messages on console seem to suggest that kopete tries to display the MSN contact image even when there is no image to display... libpng error: Read Error QImage::smoothScale: Image is a null image
Comment
#1
Matt Rogers 2004-04-30 06:04:35
patch pending approval in kopete-devel.
Comment
#2
Matt Rogers 2004-04-30 21:10:56
CVS commit by mattr: Don't try to read the image if the file size is zero. Should fix
bug 77100
CCMAIL:
77100-done@bugs.kde.org
M +3 -1 msnmessagemanager.cpp 1.95 --- kdenetwork/kopete/protocols/msn/msnmessagemanager.cpp #1.94:1.95 @@ -21,4 +21,5 @@ #include <qimage.h> #include <qtooltip.h> +#include <qfile.h> #include <kconfig.h> @@ -502,5 +503,6 @@ void MSNMessageManager::slotDisplayPictu if ( c && m_image ) { - if ( c->displayPicture() ) + KTempFile* tempFile = c->displayPicture(); + if ( tempFile && tempFile->file() && tempFile->file()->size() != 0 ) { // FIXME: don't duplicate this code with the c'tor - Martijn
Comment
#3
Matt Rogers 2004-04-30 21:11:53
CVS commit by mattr: Backport the fix for 77100. Should be in KDE 3.2.3 CCMAIL:
77100@bugs.kde.org
M +3 -1 msnmessagemanager.cpp 1.91.2.2 --- kdenetwork/kopete/protocols/msn/msnmessagemanager.cpp #1.91.2.1:1.91.2.2 @@ -21,4 +21,5 @@ #include <qimage.h> #include <qtooltip.h> +#include <qfile.h> #include <kconfig.h> @@ -492,5 +493,6 @@ void MSNMessageManager::slotDisplayPictu if ( c && m_image ) { - if ( c->displayPicture() ) + KTempFile* tempFile = c->displayPicture(); + if ( tempFile && tempFile->file() && tempFile->file()->size() != 0 ) { // FIXME: don't duplicate this code with the c'tor - Martijn
P
latform
:
unspecified
O
S
:
Linux
K
eywords
:
U
RL
:
People
Reporter
:
Assigned To
:
Kopete Developers
Related actions
View Bug Activity
Format For Printing
XML
Clone This Bug
Note
You need to
log in
before you can comment on or make changes to this bug.
Attachments
Add an attachment
(proposed patch, testcase, etc.)
Depends on
:
B
locks
:
Show dependency tree
-
Show dependency graph
First
Last
Prev
Next
No search results available
Search page
Actions
Reports
Requests
Reports
Bugs reported today
Bugs reported in the last 3 days
Bug reports with patches
Weekly Bug statistics
The most hated bugs
The most severe bugs
The most frequently reported bugs
The most wanted features
Junior Jobs
Report ownership counts and charts
My Account
New Account
Log In