KDE Bug Tracking System
Home
Report New Wish or Bug
Query Existing Reports
First
Last
Prev
Next
No search results available
Search page
Bug
75333
:
rgb colors with values less than 16 can't be tr...
P
roduct
:
knode
Co
m
ponent
:
general
Status
:
RESOLVED
Resolution
:
FIXED
Target
:
---
Version
:
unspecified
Pr
i
ority
:
NOR
Severity
:
normal
V
otes
:
0
Description
:
Opened:
2004-02-16 09:36
Last Changed:
2004-03-08 09:14:48
Version: (using KDE KDE 3.2.0) Installed from: SuSE RPMs OS: Linux When specifying what colors to use, knode can't use colors whose red, green, or blue value is less than 16, e.g. when specifying a kind of red (with rgb 255,15,16) for the first citation level, knode gives this error message when trying to display a message that contains this citation level: QColor::setNamedColor: could not parse color '#ff f10' This is true only for qt3.3.0 (at least it didn't happen befor upgrading to that version). Since kmail can handle such colors, I consider it a knode bug.
Comment
#1
Volker Krause 2004-03-06 16:52:09
CVS commit by vkrause: Remove manual QColor to hexcode conversion and use QColor::name() instead. CCMAIL:
75333-done@bugs.kde.org
M +10 -7 knconfig.cpp 1.76 M +3 -5 knconfig.h 1.69 M +0 -1 knconfigwidgets.cpp 1.101 M +0 -1 knmainwidget.cpp 1.22 --- kdepim/knode/knconfig.cpp #1.75:1.76 @@ -257,6 +257,4 @@ KNConfig::Appearance::Appearance() f_ontNames[articleList]=i18n("Article List"); - updateHexcodes(); - //icons recreateLVIcons(); @@ -491,10 +489,15 @@ QFont KNConfig::Appearance::articleListF -void KNConfig::Appearance::updateHexcodes() +QString KNConfig::Appearance::quotedTextHexcode(int i) { - sprintf(h_excodes[quoted1Hex], "#%2x%2x%2x", quoteColor1().red(), quoteColor1().green(), quoteColor1().blue()); - sprintf(h_excodes[quoted2Hex], "#%2x%2x%2x", quoteColor2().red(), quoteColor2().green(), quoteColor2().blue()); - sprintf(h_excodes[quoted3Hex], "#%2x%2x%2x", quoteColor3().red(), quoteColor3().green(), quoteColor3().blue()); - sprintf(h_excodes[headerHex], "#%2x%2x%2x", headerDecoColor().red(), headerDecoColor().green(), headerDecoColor().blue()); + switch(i) { + case quoted1Hex: + return quoteColor1().name(); + case quoted2Hex: + return quoteColor2().name(); + case quoted3Hex: + return quoteColor3().name(); + } + return textColor().name(); } --- kdepim/knode/knconfig.h #1.68:1.69 @@ -321,5 +321,5 @@ class Appearance : public Base { unreadArticle=10, readArticle=11, activeItem=12, selectedItem=13 }; - enum HexIndex { quoted1Hex=0, quoted2Hex=1, quoted3Hex=2, headerHex=3 }; + enum HexIndex { quoted1Hex=0, quoted2Hex=1, quoted3Hex=2 }; enum FontIndex { article=0, articleFixed=1, composer=2, groupList=3, articleList=4 }; @@ -351,7 +351,6 @@ class Appearance : public Base { QColor selectedItemColor(); - const char* headerDecoHexcode() { return h_excodes[headerHex]; } - const char* quotedTextHexcode(int i) { return h_excodes[i]; } - void updateHexcodes(); + QString headerDecoHexcode() { return headerDecoColor().name(); } + QString quotedTextHexcode(int i); QFont articleFont(); @@ -382,5 +381,4 @@ class Appearance : public Base { QFont f_onts[FNT_CNT]; QString f_ontNames[FNT_CNT]; - char h_excodes[HEX_CNT][8]; QPixmap i_cons[ICON_CNT]; --- kdepim/knode/knconfigwidgets.cpp #1.100:1.101 @@ -819,5 +819,4 @@ void KNConfig::AppearanceWidget::apply() d_ata->setDirty(true); - d_ata->updateHexcodes(); d_ata->recreateLVIcons(); } --- kdepim/knode/knmainwidget.cpp #1.21:1.22 @@ -1016,5 +1016,4 @@ void KNMainWidget::fontChange( const QFo void KNMainWidget::paletteChange( const QPalette & ) { - c_fgManager->appearance()->updateHexcodes(); KNArticleWidget::configChanged(); configChanged();
Comment
#2
Volker Krause 2004-03-07 18:16:45
***
Bug 75080
has been marked as a duplicate of this bug. ***
P
latform
:
SuSE RPMs
O
S
:
Linux
K
eywords
:
U
RL
:
People
Reporter
:
Ralf Goertz
Assigned To
:
KNode Developers
Related actions
View Bug Activity
Format For Printing
XML
Clone This Bug
Note
You need to
log in
before you can comment on or make changes to this bug.
Attachments
Add an attachment
(proposed patch, testcase, etc.)
Depends on
:
B
locks
:
Show dependency tree
-
Show dependency graph
First
Last
Prev
Next
No search results available
Search page
Actions
Reports
Requests
Reports
Bugs reported today
Bugs reported in the last 3 days
Bug reports with patches
Weekly Bug statistics
The most hated bugs
The most severe bugs
The most frequently reported bugs
The most wanted features
Junior Jobs
Report ownership counts and charts
My Account
New Account
Log In