Bug 64506 – [test case] revsced barkets in tags using "dir=rtl" (regression)

First Last Prev Next No search results available Search page

Bug 64506:

[test case] revsced barkets in tags using "dir=...

Product:	konqueror
Component:	khtml renderer
Status:	RESOLVED
Resolution:	FIXED
Target:	---

Version:	unspecified
Priority:	NOR
Severity:	major

Votes:

Description:
Opened: 2003-09-18 21:31 Last Changed: 2004-10-26 19:06:21

Version: (using KDE Devel) Installed from: Compiled sources There are brakets reversed in some html pages. I managed to find exactly when it happens: <html> <body> <div dir="rtl"> טקסט עברי no bidi text (עברית english) עברית </div> <br><br><br> <div dir="ltr"> טקסט עברי no bidi text (עברית english) עברית </div> </body> </html> the first will be showed incorreclty and thelats will be OK. In the branch both are ok. (qt does not reversed the brakets in X 4.3 no more, that may be the cause). When you finish fix this bug, please cc me the diff.

Comment #1 Diego Iastrubni 2003-09-18 21:32:47

Created an attachment (id=2507) [details] this file triggers the bug

Comment #2 maor 2003-10-31 09:33:21

Created an attachment (id=2946) [details] pic in konqueror at the same subject (i think) i'm adding screen shot of konqueror showing bidi text starting with rtl lang showing it from left to right, the page adress: http://www.netaction.co.il/cat.phtml?cat=8

Comment #3 Allan Sandfeld 2004-10-26 13:30:45

CVS commit by carewolf: Big Bad Bidi Merge. Merging all changes in bidi.cpp from Webcore/125, and selected ones from Webcore/146. This results in 2182 benign changes in regression outputs. BUG: 54916 BUG: 59476 BUG: 62904 BUG: 64506 BUG: 69806 BUG: 74800 BUG: 79365 BUG: 86157 M +15 -1 ChangeLog 1.315 M +976 -592 rendering/bidi.cpp 1.197 M +25 -57 rendering/bidi.h 1.19 M +3 -3 rendering/render_block.h 1.20 M +3 -1 rendering/render_list.h 1.36 M +4 -3 rendering/render_object.h 1.198

Comment #4 Diego Iastrubni 2004-10-26 15:21:09

no no no... this is not good... are you sure? i am running the branch here and life is good. trust me! Those problems were in qx11painter and lars fixed those in tbe aKademy. The fixes are in Qt copy. The testcase is showed PERFECTLY here on my Qt-copy+kde3.3.branch. Can you give me details about your system? --- Allan Sandfeld <kde@carewolf.com> wrote: > ------- You are receiving this mail because: ------- > You reported the bug, or are watching the reporter. > > http://bugs.kde.org/show_bug.cgi?id=64506 > kde carewolf com changed: > > What |Removed > |Added > ---------------------------------------------------------------------------- > Status|NEW > |RESOLVED > Resolution| > |FIXED > > > > ------- Additional Comments From kde carewolf com > 2004-10-26 13:30 ------- > CVS commit by carewolf: > > Big Bad Bidi Merge. > Merging all changes in bidi.cpp from Webcore/125, > and selected ones > from Webcore/146. > > This results in 2182 benign changes in regression > outputs. > > BUG: 54916 > BUG: 59476 > BUG: 62904 > BUG: 64506 > BUG: 69806 > BUG: 74800 > BUG: 79365 > BUG: 86157 > > > M +15 -1 ChangeLog 1.315 > M +976 -592 rendering/bidi.cpp 1.197 > M +25 -57 rendering/bidi.h 1.19 > M +3 -3 rendering/render_block.h 1.20 > M +3 -1 rendering/render_list.h 1.36 > M +4 -3 rendering/render_object.h 1.198 > __________________________________ Do you Yahoo!? Yahoo! Mail Address AutoComplete - You start. We finish. http://promotions.yahoo.com/new_mail

Comment #5 Allan Sandfeld 2004-10-26 15:33:59

Yes, it looks like you are right. The bug was already fixed in the version of Konqueror 3.3 I have. Seems like I missed the double-check on this one, but fixed it is.

Comment #6 Diego Iastrubni 2004-10-26 15:57:01

Hi Allan, The problem was not in khtml, but in Qt. The patch is http://68.118.205.171/cgi-bin/cvsweb.cgi/qt-copy/patches/0052-bidifixes.patch it was written by Lars Knoll in the aKademy. What other fixes did you do to bidi.cpp? You probably fixed some other bugs, spacing issues maybe? text overlapping each other?. I was not able to recreate that bug in a clean HTML, but it is found in the wild (for example http://www.kde.org/il). I will open a bug soon if you say that it's not fixed. anyway, this bug should be closed anyway :) --- Allan Sandfeld <kde@carewolf.com> wrote: > ------- You are receiving this mail because: ------- > You reported the bug, or are watching the reporter. > > http://bugs.kde.org/show_bug.cgi?id=64506 > > > > > ------- Additional Comments From kde carewolf com > 2004-10-26 15:33 ------- > Yes, it looks like you are right. The bug was > already fixed in the version of Konqueror 3.3 I > have. Seems like I missed the double-check on this > one, but fixed it is. > __________________________________ Do you Yahoo!? Yahoo! Mail Address AutoComplete - You start. We finish. http://promotions.yahoo.com/new_mail

Comment #7 Allan Sandfeld 2004-10-26 19:06:21

There are still overlapping text in www.kde.org/il. So you better open a new bug.

Platform:	Compiled Sources
OS:	Linux
Keywords:

People

Reporter:	Diego Iastrubni
Assigned To:	Konqueror Developers

Related actions

Note

You need to log in before you can comment on or make changes to this bug.

Attachments
this file triggers the bug (218 bytes, text/html) 2003-09-18 21:32, Diego Iastrubni	Details
pic in konqueror (203.17 KB, image/png) 2003-10-31 09:33, maor	Details
View All Add an attachment (proposed patch, testcase, etc.)

Depends on:
Blocks:
	Show dependency tree - Show dependency graph

First Last Prev Next No search results available Search page

Actions

Reports

My Account