I'm not sure why the text is misaligned, please consider attaching a document
for us to test.

I just created a document in hebrew in KWord and I can reproduce the lack of
the RTL button appearing on load.

As a workaround you might want to alter a paragraph with mostly hebrew and type
at least one character. You will see a button labeled "RTL" appear on the
tool-options docker that allows you to change the direction of the text.

you are right. starting to type i get this button which works fine.
but, it does not apply for the entire text (when i select it)
and when i keep typing in herbrew and press enter to go down a line
the alignment goes left. and not as it was a line ago.

i am attaching a problematic document ODF

Created an attachment (id=31235) [details]
entire document is aligned to the left and considered LTR

originally, this document is aligned to the right (in OOo 3) and "bidi marked"
as RTL (in each paragraph).

The align button add/change/appear via
KoTextEditor::Private::runDirectionUpdater()

However, I didn't find any method in KoTextEditor which occur after the
document load and it didn't work when I call it from the constructor.

Also updateRtlTimer.start(); in the constructor didn't help (the document load
empty).

is there any chance that runDirectionUpdater won't be private?

There is a some logic which it may be private as the KoTextEditor need to know
which text is insert, however when opening a document, KoTextEditor isn't used
to display its contect.

Maybe you can add a 'KoTextEditor::finishedLoading()' method that checks for
bidi-ness of the document.

Created an attachment (id=41576) [details]
add KoTextEditor::finishedLoading

Can I commit?

Hi Nadav,

Thomas thinks this was already committed. Could you please close your
reviewboard request as well (http://reviewboard.kde.org/r/3273/)?

Thanks!

well, i am not sure...
i use KWord 2.1.1-1 (Debian unstable) and i just opened an ODF (Hebrew) file
which was visually aligned to the left while the toolbar's align-right button
was pressed.

i selected all the text, pressed the "align-left" button and then the
"align-right" button and it was justified correctly. which was suppose to be
the initial state.

btw, you should be using RTL/LTR button too. not just text alignments button.
please see how OpenOffice Writer has implemented this. i think it is the cause
to this issue, in the first place. as far as i can understand.

:-)

@ Nadav The fix was for 2.2, so it makes sense you don't see the bug fixed in
your 2.1 version.

oups, i missed that small detail.

in that case... let's keep it close.

And the request on reviewboard.kde.org -- you are the only one who can close
that.

well, that's not me that's the other nadav... nadavvin
i am nadavkav.

i know him and he is CC to this correspondent.

are you not ? (nadavvin)
:-)

"are you not ? (nadavvin)
"

yes, it's me...

Sorry I didn't have time to close the bug...