Bug 136671 - Crash when showing filters gallery for water color image

Bug 136671 - Crash when showing filters gallery for water color image


Summary:	Crash when showing filters gallery for water color image

Product:	krita
Component:	general
Status:	RESOLVED
Resolution:	FIXED
Target:	---

Version:	unspecified
Priority:	NOR
Severity:	crash

Votes:

Version Fixed In:

Description From Eckhart Wörner 2006-11-01 21:51:14

Version:           1.6.0 (using KDE 3.5.5, Debian Package 4:3.5.5a.dfsg.1-2
(testing/unstable))
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.17-2-686

To reproduce:
- create a new water color image
- choose "Filter" -> "Filters gallery"
Result:
- crashes with backtrace:

Using host libthread_db library "/lib/tls/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread -1232029472 (LWP 3174)]
[KCrash handler]
#5  QValueListPrivate<KisTileManager::TileInfo*>::remove (this=0x87fa710, 
    it=@0xbffe3318) at /usr/share/qt3/include/qvaluelist.h:304
#6  0xb62f0efa in KisTileManager::ensureTileLoaded (this=0x87fa690, 
    tile=0x8930328) at /usr/share/qt3/include/qvaluelist.h:495
#7  0xb62f0f71 in KisTile::addReader (this=0x8930328)
    at /tmp/buildd/koffice-1.6.0/./krita/core/tiles/kis_tile.cc:140
#8  0xb62f3e22 in KisTiledIterator::fetchTileData (this=0x8820298, col=1, 
    row=0)
    at /tmp/buildd/koffice-1.6.0/./krita/core/tiles/kis_tilediterator.cc:120
#9  0xb62f3f2a in KisTiledRectIterator::operator++ (this=0x8820298)
    at
/tmp/buildd/koffice-1.6.0/./krita/core/tiles/kis_tiledrectiterator.cc:179
#10 0xb62ae895 in KisRectIterator::operator++ (this=0xbffe33fc)
    at /tmp/buildd/koffice-1.6.0/./krita/core/kis_iterator.cc:55
#11 0xb5b79c5d in KisFilterColorToAlpha::process (this=0x816d090, 
    src=@0xbffe3494, dst=@0xbffe3490, config=0x8911d88, rect=@0x8a53c58)
    at
/tmp/buildd/koffice-1.6.0/./krita/plugins/filters/colors/../../../core/kis_iterators_pixel.h:121
#12 0xb61e2087 in KisFiltersThumbnailThread::run (this=0x8a53c38)
    at /tmp/buildd/koffice-1.6.0/./krita/ui/kis_filters_listview.cc:65
#13 0xb61e30e4 in KisFiltersListView::buildPreview (this=0x87fe2a8)
    at /tmp/buildd/koffice-1.6.0/./krita/ui/../core/kis_thread.h:48
#14 0xb61e34a6 in KisFiltersListView::setLayer (this=0x87fe2a8, 
    layer=@0xbffe3784)
    at /tmp/buildd/koffice-1.6.0/./krita/ui/kis_filters_listview.cc:170
#15 0xaaf68483 in KisDlgFiltersGallery (this=0xbffe3830, view=0x885c638, 
    parent=0x885c638, name=0xaaf69e56 "")
    at
/tmp/buildd/koffice-1.6.0/./krita/plugins/viewplugins/filtersgallery/kis_dlg_filtersgallery.cc:50
#16 0xaaf68a23 in
Krita::Plugins::FiltersGallery::KritaFiltersGallery::showFiltersGalleryDialog
(this=0x89f1d48)
    at
/tmp/buildd/koffice-1.6.0/./krita/plugins/viewplugins/filtersgallery/filters_gallery.cc:84
#17 0xaaf69032 in
Krita::Plugins::FiltersGallery::KritaFiltersGallery::qt_invoke (this=0x89f1d48,
_id=2, _o=0xbffe3a2c) at ./filters_gallery.moc:82
#18 0xb72c0cb3 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#19 0xb72c1744 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#20 0xb6cee259 in KAction::activated (this=0x8a0f808) at ./kaction.moc:176
#21 0xb6d23961 in KAction::slotActivated (this=0x8a0f808)
    at /home/sid-user/kdelibs/kdelibs-3.5.5/./kdeui/kaction.cpp:1102
#22 0xb6e03c0d in KAction::slotPopupActivated (this=0x8a0f808)
    at /home/sid-user/kdelibs/kdelibs-3.5.5/./kdeui/kaction.cpp:1137
#23 0xb6e03ed1 in KAction::qt_invoke (this=0x8a0f808, _id=16, _o=0xbffe3b68)
    at ./kaction.moc:219
#24 0xb72c0cb3 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#25 0xb7649cef in QSignal::signal () from /usr/lib/libqt-mt.so.3
#26 0xb72e0836 in QSignal::activate () from /usr/lib/libqt-mt.so.3
#27 0xb73e5cb1 in QPopupMenu::mouseReleaseEvent () from /usr/lib/libqt-mt.so.3
#28 0xb6cf70ee in KPopupMenu::mouseReleaseEvent (this=0x8a61f58, e=0xbffe40a4)
    at /home/sid-user/kdelibs/kdelibs-3.5.5/./kdeui/kpopupmenu.cpp:508
#29 0xb72f7654 in QWidget::event () from /usr/lib/libqt-mt.so.3
#30 0xb7258bd6 in QApplication::internalNotify () from /usr/lib/libqt-mt.so.3
#31 0xb725ad79 in QApplication::notify () from /usr/lib/libqt-mt.so.3
#32 0xb794ee0e in KApplication::notify (this=0xbffe465c, receiver=0x8a61f58, 
    event=0xbffe40a4)
    at /home/sid-user/kdelibs/kdelibs-3.5.5/./kdecore/kapplication.cpp:550
#33 0xb71ec445 in QApplication::sendSpontaneousEvent ()
   from /usr/lib/libqt-mt.so.3
#34 0xb71eae38 in QETWidget::translateMouseEvent ()
   from /usr/lib/libqt-mt.so.3
#35 0xb71e9660 in QApplication::x11ProcessEvent () from /usr/lib/libqt-mt.so.3
#36 0xb71ffcb2 in QEventLoop::processEvents () from /usr/lib/libqt-mt.so.3
#37 0xb7273129 in QEventLoop::enterLoop () from /usr/lib/libqt-mt.so.3
#38 0xb7272f4a in QEventLoop::exec () from /usr/lib/libqt-mt.so.3
#39 0xb725a76f in QApplication::exec () from /usr/lib/libqt-mt.so.3
#40 0xb7fa8095 in kdemain (argc=1, argv=0x805b560)
    at /tmp/buildd/koffice-1.6.0/./krita/main.cc:41
#41 0xb7faa524 in kdeinitmain (argc=1, argv=0x805b560) at krita_dummy.cc:3
#42 0x0804e457 in launch (argc=1, _name=0x8076aac "krita", 
    args=0x8076ab2 "\001", cwd=0x0, envc=1, envs=0x8076ac2 "", 
    reset_env=false, tty=0x0, avoid_loops=false, 
    startup_id_str=0x8076ac7 "jedi;1162407372;699039;3010_TIME2766202709")
    at /home/sid-user/kdelibs/kdelibs-3.5.5/./kinit/kinit.cpp:673
#43 0x0804ecf9 in handle_launcher_request (sock=9)
    at /home/sid-user/kdelibs/kdelibs-3.5.5/./kinit/kinit.cpp:1240
#44 0x0804f092 in handle_requests (waitForPid=0)
    at /home/sid-user/kdelibs/kdelibs-3.5.5/./kinit/kinit.cpp:1443
#45 0x080502b1 in main (argc=5, argv=0xbffe4e04, envp=0xbffe4e1c)
    at /home/sid-user/kdelibs/kdelibs-3.5.5/./kinit/kinit.cpp:1909
#46 0xb7d22ea8 in __libc_start_main () from /lib/tls/libc.so.6
#47 0x0804b911 in _start () at ../sysdeps/i386/elf/start.S:119

------- Comment #1 From Cyrille Berger 2006-11-02 00:56:05 -------

SVN commit 601075 by berger:

forward port: fix crash with color to alpha and watercolor (and a memory leak)àB
CCBUG:136671


 M  +3 -3      kis_color_to_alpha.cc  


--- trunk/koffice/krita/plugins/filters/colors/kis_color_to_alpha.cc #601074:601075
@@ -70,10 +70,9 @@
     setProgressTotalSteps(size.width() * size.height());
 
     KoColorSpace * cs = src->colorSpace();
-//     Q_INT32 nchannels = cs->nChannels();
-    Q_INT32 ncolors = cs->nColorChannels();
+    Q_INT32 pixelsize = cs->pixelSize();
     
-    Q_UINT8* color = new Q_UINT8[ncolors];
+    Q_UINT8* color = new Q_UINT8[pixelsize];
     cs->fromQColor(cTA, color);
     
     while( ! srcIt.isDone() )
@@ -92,5 +91,6 @@
         ++srcIt;
         ++dstIt;
     }
+    delete[] color;
     setProgressDone(); // Must be called even if you don't really support progression
 }

------- Comment #2 From Cyrille Berger 2006-11-02 00:56:24 -------

SVN commit 601076 by berger:

 fix crash with color to alpha and watercolor (and a memory leak)àB
BUG:136671



 M  +3 -3      kis_color_to_alpha.cc  


--- branches/koffice/1.6/koffice/krita/plugins/filters/colors/kis_color_to_alpha.cc #601075:601076
@@ -69,10 +69,9 @@
     setProgressTotalSteps(rect.width() * rect.height());
 
     KisColorSpace * cs = src->colorSpace();
-//     Q_INT32 nchannels = cs->nChannels();
-    Q_INT32 ncolors = cs->nColorChannels();
+    Q_INT32 pixelsize = cs->pixelSize();
     
-    Q_UINT8* color = new Q_UINT8[ncolors];
+    Q_UINT8* color = new Q_UINT8[pixelsize];
     cs->fromQColor(cTA, color);
     
     while( ! srcIt.isDone() )
@@ -91,5 +90,6 @@
         ++srcIt;
         ++dstIt;
     }
+    delete[] color;
     setProgressDone(); // Must be called even if you don't really support progression
 }

Platform:	unspecified
OS:	Linux
Keywords:
URL:

People

Reporter:	Eckhart Wörner
Assigned To:	Krita Bugs

Related actions

View Bug Activity

Format For Printing

Clone This Bug

Search for Duplicates

Note

You need to log in before you can comment on or make changes to this bug.

Attachments
Add an attachment (proposed patch, testcase, etc.)

Depends on:
Blocks:
	Show dependency tree - Show dependency graph

Actions

Reports

My Account