KDE Bug Tracking System
Home
Report New Wish or Bug
Query Existing Reports
First
Last
Prev
Next
No search results available
Search page
Bug
135470
:
fill tool does not fill entire selection if sel...
P
roduct
:
krita
Co
m
ponent
:
Tools
Status
:
RESOLVED
Resolution
:
FIXED
Target
:
---
Version
:
svn trunk
Pr
i
ority
:
NOR
Severity
:
normal
V
otes
:
0
Description
:
Opened:
2006-10-11 21:06
Last Changed:
2006-11-06 16:14:11
press ctrl-a or choose selection/select all. Select the fill tool. Check "fill entire selection". Click. Nothing is getting filled!
Comment
#1
boud valdyas org 2006-11-03 12:41:25
I'm fairly sure that this is caused by the exact bounds of a layer coincide with the exact bounds of the selection: probably isPorbablyTotallyUnselected is wrong here. Since that's Cyrille's baby, assign to him.
Comment
#2
Cyrille Berger 2006-11-03 13:03:53
hein ? is it my baby ?
Comment
#3
boud valdyas org 2006-11-03 13:10:13
The probabilistic determination of whether a layer is totally selected or unselected is, isn't it?
Comment
#4
boud valdyas org 2006-11-06 15:51:18
No, it's bart!
Comment
#5
Bart Coppens 2006-11-06 16:14:10
SVN commit 602692 by coppens: Call the apropriate function instead (exactRect on a selection messes up with inverted selections like Select All). BUG:135470 M +1 -1 kis_tool_fill.cc --- branches/koffice/1.6/koffice/krita/plugins/tools/defaulttools/kis_tool_fill.cc #602691:602692 @@ -81,7 +81,7 @@ if (!device) return false; if (m_fillOnlySelection) { - QRect rc = device->selection()->exactBounds(); + QRect rc = device->selection()->selectedRect(); KisPaintDeviceSP filled = new KisPaintDevice(device->colorSpace(), "filled"); KisFillPainter painter(filled); if (m_usePattern)
P
latform
:
Unlisted Binaries
O
S
:
Linux
K
eywords
:
People
Reporter
:
Assigned To
:
Bart Coppens
Related actions
View Bug Activity
Format For Printing
XML
Clone This Bug
Note
You need to
log in
before you can comment on or make changes to this bug.
Attachments
Add an attachment
(proposed patch, testcase, etc.)
Depends on
:
B
locks
:
Show dependency tree
-
Show dependency graph
First
Last
Prev
Next
No search results available
Search page
Actions
Reports
Requests
Reports
Bugs reported today
Bugs reported in the last 3 days
Bug reports with patches
Weekly Bug statistics
The most hated bugs
The most severe bugs
The most frequently reported bugs
The most wanted features
Junior Jobs
Report ownership counts and charts
My Account
New Account
Log In