Version: 1.6-svn (using KDE KDE 3.5.4) Installed from: Ubuntu Packages Compiler: gcc 4.1.x OS: Linux Warning: this might bring your computer down if you don't kill krita quickly: - in a new image - select the fill tool with the tablet - try to fill the image - kill krita before it eats all memory
Could this have something to do with Sebastian Sauer's optimizations in the progress bar code?
I doubt it, because 1) I haven't updated my copy to sebastian's optimization 2) I pretty sure it has happen before, but it was at the beginning of me playing with a tablet, so I wasn't too sure what exactly went wrong
Pity... Now it looks like we will need Adrian for this bug.
SVN commit 599731 by berger: fix the fill tool going made when use with the tablet in 1.6, don't close the bug as we might want a better solution for 2.0 CCBUG:133148 M +4 -1 kis_tool_fill.cc M +1 -0 kis_tool_fill.h --- branches/koffice/1.6/koffice/krita/plugins/tools/defaulttools/kis_tool_fill.cc #599730:599731 @@ -50,7 +50,7 @@ #include "kis_selection.h" KisToolFill::KisToolFill() - : super(i18n("Fill")) + : super(i18n("Fill")), m_wasPressed(false) { setName("tool_fill"); m_subject = 0; @@ -138,10 +138,13 @@ void KisToolFill::buttonPress(KisButtonPressEvent *e) { m_startPos = e->pos(); + m_wasPressed = true; } void KisToolFill::buttonRelease(KisButtonReleaseEvent *e) { + if(!m_wasPressed) return; + m_wasPressed = false; if (!m_subject) return; if (!m_currentImage || !m_currentImage->activeDevice()) return; if (e->button() != QMouseEvent::LeftButton) return; --- branches/koffice/1.6/koffice/krita/plugins/tools/defaulttools/kis_tool_fill.h #599730:599731 @@ -79,6 +79,7 @@ QCheckBox *m_checkUsePattern; QCheckBox *m_checkSampleMerged; QCheckBox *m_checkFillSelection; + bool m_wasPressed; // use for preventing bug:133148 };
Better close the bug: the 2.0 situation is already so very different that this bug isn't relevant for that code anymore.
You need to log in before you can comment on or make changes to this bug.