Version: 1.5.0 (using KDE 3.4.3, Kubuntu Package 4:3.4.3-0ubuntu2 ) Compiler: Target: i486-linux-gnu OS: Linux (i686) release 2.6.12-10-k7 If I search a word inside a document, close the search dialog and then go back again, the previous search will be shown as an option in a combobox. This same thing doesn't happen in the replace dialog, which doesn't remember previous searches. In fact, the replace dialog remembers a search only if it has been performed using the search dialog, but not if it has been done from replace dialog.
I can confirm this; I guess some missing code. Good for a junior job :)
Created an attachment (id=15852) [details] patch to fix this It's not even missing code, just a messed-up conditional. The attached patch fixes it; please review and check in. (Patch is against 1.5 branch, but should also apply to trunk.)
SVN commit 536876 by dfaure: Apply patch by Benjamin K.Stuhl <benjamin.stuhl colorado.edu> to fix "replace dialog searches are not remembered". Thanks! BUG: 125444 M +2 -2 KoSearchDia.cpp --- branches/koffice/1.5/koffice/lib/kotext/KoSearchDia.cpp #536875:536876 @@ -135,9 +135,9 @@ KReplaceDialog::slotOk(); // Save the current state back into the context required. - m_findUI->setCtxOptions( KReplaceDialog::options() ); + m_findUI->setCtxHistory( findHistory() ); if ( optionFindSelected() ) - m_findUI->setCtxHistory( findHistory() ); + m_findUI->setCtxOptions( KReplaceDialog::options() ); m_replaceUI->setCtxHistory( replacementHistory() ); if ( optionReplaceSelected() )
You need to log in before you can comment on or make changes to this bug.
KDE Bug Tracking System
KDE Bug Tracking System 