| Bug 125216: More intrusive warning when altering table design | (normal) |
| Opened: | 2006-04-09 13:18 |
| Product: | kexi |
| Component: | Table Designer |
| Version: | unspecified |
| Status: | RESOLVED |
| Platform: | Gentoo Packages |
| Resolution: | FIXED |
| Reporter: | Bram Schoenmakers |
| Assigned to: | Jaroslaw Staniek |
Version: 1.5 rc1 (SVN: 1.5 branch, 8 April 2006) (using KDE KDE 3.4.3)
Installed from: Gentoo Packages
Compiler: gcc 3.4.5
OS: Linux
When I alter a table with some data in it and I modify the table design, it shows me a warning that all data will be lost when you proceed.
In my opinion, the warning is not intrusive enough (it's mentioned with a "Note:"). Also the icon could be changed to an warning (exclamation). I believe it's easy that someone easily looses their data this way.
BTW, is it possible (in the future) to alter the database design with Kexi without losing data?
------- Additional Comment #1 From Jaroslaw Staniek 2006-04-09 21:59 -------
> BTW, is it possible (in the future) to alter the database design
> with Kexi without losing data?
Yes, this is hot TODO for 1.1 (KOffice 1.6). Could you please file a WISH just for this?
------- Additional Comment #2 From Jaroslaw Staniek 2006-04-09 22:02 -------
SVN commit 527984 by staniek:
Table Designer
- More intrusive warning when altering table design
1.0: ported (except the message)
2.0: ported
CCMAIL:125216-done at bugs.kde.org
M +3 -2 kexialtertabledialog.cpp
M +1 -1 kexitablepart.cpp
--- branches/koffice/1.6/koffice/kexi/plugins/tables/kexialtertabledialog.cpp #527983:527984
at at -565,10 +565,11 at at
// KexiDB::Connection *conn = mainWin()->project()->dbConnection();
bool emptyTable;
- int r = KMessageBox::questionYesNoCancel(this,
+ int r = KMessageBox::warningYesNoCancel(this,
i18n("Saving changes for existing table design is now required.")
+"\n"+messageForSavingChanges(emptyTable), QString::null,
- KStdGuiItem::save(), KStdGuiItem::discard());
+ KStdGuiItem::save(), KStdGuiItem::discard(), QString::null,
+ KMessageBox::Notify|KMessageBox::Dangerous);
if (r == KMessageBox::Cancel)
res = cancelled;
else
--- branches/koffice/1.6/koffice/kexi/plugins/tables/kexitablepart.cpp #527983:527984
at at -195,7 +195,7 at at
if (dlg->currentViewMode()==Kexi::DesignViewMode && !dlg->neverSaved()
&& englishMessage==":additional message before saving design")
- return i18n("Note: Any data in this table will be removed upon design's saving.");
+ return i18n("Warning! Any data in this table will be removed upon design's saving!");
return englishMessage;
}
| Attachment | Type | Modified | Status | Actions |
|---|---|---|---|---|
| Create a New Attachment (proposed patch, testcase, etc.) | View All | |||
Bugs.KDE.Org Actions