Version: 1.5 beta2 (using KDE KDE 3.5.1) Installed from: Gentoo Packages Compiler: gcc-Version 3.4.5 (Gentoo 3.4.5, ssp-3.4.5-1.0, pie-8.7.9) OS: Linux Rightclick on an unactivated splitview crashes krita. Steps to reproduce: 1. Split the view in two 2. Activate one view (for instance with a middleclick) 3. Do a rightclick on the other view 4. Greet Dr. Konqi
Created an attachment (id=15079) [details] backtrace
Thanks, I can confirm.
Fixed. Changing views is as ugly as a joyless sin, but no crashes anymore. Thanks for the report, and thanks to Peter Simonssen for helping fix it.
I can still reproduce the crash but with a slightly different method: 1. Open a picture 2. Split the view in two 3. Activate one view (for instance with a middleclick) and do a rightclick on this view 3. Do a rightclick on the other view KDE Version 1.6.0 (KDE 3.5.5, Kubuntu (edgy) 4:3.5.5-0ubuntu3) Application KOffice Image Manipulation Application Operating System Linux (i686) release 2.6.17-10-generic Compiler Target: i486-linux-gnu
[Sorry, I unintentionally commited my previous post...] I can still reproduce the crash but with a slightly different method: 1. Open a picture 2. Split the view in two 3. Activate the first view (for instance with a middleclick) and do a rightclick on this view 4. Activate the second view (for instance with a middleclick) and do a rightclick on this view 5. Activate the first view (for instance with a middleclick) and do a rightclick on this view 6. Greet Dr. Konqi® KDE Version 1.6.0 (KDE 3.5.5, Kubuntu (edgy) 4:3.5.5-0ubuntu3) Application KOffice Image Manipulation Application Operating System Linux (i686) release 2.6.17-10-generic Compiler Target: i486-linux-gnu (good luck... :-/)
Yes, you're right. Not sure what's happening, but there's definitely a crash. Thanks for discovering this!
SVN commit 617546 by rempt: BUG: 123500 This time it should be fixed for good, I went through twenty activations + right clicks. M +5 -4 kis_view.cc M +0 -1 kis_view.h --- branches/koffice/1.6/koffice/krita/ui/kis_view.cc #617545:617546 @@ -175,7 +175,6 @@ , m_oldTool( 0 ) , m_doc( doc ) , m_canvas( 0 ) - , m_popup( 0 ) , m_partHandler( 0 ) , m_gridManager( 0 ) , m_perspectiveGridManager( 0 ) @@ -2307,12 +2306,14 @@ // } // } if (e->button() == Qt::RightButton) { - - if (m_popup == 0 && factory()) { + QPopupMenu * m_popup = 0; + if (factory()) { Q_ASSERT(factory()); m_popup = (QPopupMenu *)factory()->container("image_popup", this); } - if (m_popup) m_popup->popup(e->globalPos().roundQPoint()); + if (m_popup) { + m_popup->popup(e->globalPos().roundQPoint()); + } } else if (e->device() == currentInputDevice() && m_toolManager->currentTool()) { KisPoint p = viewToWindow(e->pos()); --- branches/koffice/1.6/koffice/krita/ui/kis_view.h #617545:617546 @@ -521,7 +521,6 @@ KisDoc *m_doc; KisCanvas *m_canvas; - QPopupMenu * m_popup; KisPartLayerHandler* m_partHandler; KisGridManager * m_gridManager;
You need to log in before you can comment on or make changes to this bug.