Version: (using KDE KDE 3.3.2) Installed from: Debian testing/unstable Packages Nowadays I'm having problems with my internet connection (e.g. high pings and severe packet loss). When using "Upload Project" to my FTP account, it often fails, due to bad connection quality. The problem is that no retry button is offered in case of failed upload, and even when some files got uploaded, they don't get marked as up-to-date, because some others failed. What do I expect? When I try to upload the project files, let's say file1.htm, file2.htm, file3.htm. First two files get uploaded and the third doesn't because of network timeout. I expect: 1.) that correctly uploaded files are immediately marked as up-to-date 2.) that the upload dialog doesn't close 3.) that 'Proceed' button gets replaced by 'Retry' (or another offer to retry the upload) 4.) that the 'second' upload doesn't try to upload those already uploaded files again (same as expectation no.1)
SVN commit 518657 by amantia: Mark uploaded files as uploaded even if upload fails later. Proceed basicly acts like a "retry" in this case, resumes the upload from the last not-uploaded file. BUG: 111857 M +1 -0 ChangeLog M +6 -1 project/projectupload.cpp --- branches/KDE/3.5/kdewebdev/quanta/ChangeLog #518656:518657 @@ -29,6 +29,7 @@ - add possibility to limit the number of recent files/projects. No GUI, use "Recent Files Limit" in the [General Options] section [#113309] - show the project name in the window titlebar + - mark uploaded files as uploaded even if upload fails later [#111857] - new DCOP methods: - WindowManagerIf::uploadURL(url, profile, markOnly): uploads the url to the place described by profile. If --- branches/KDE/3.5/kdewebdev/quanta/project/projectupload.cpp #518656:518657 @@ -442,6 +442,7 @@ QuantaCommon::dirCreationError(this, KURL( dir.prettyURL(0, KURL::StripFileProtocol) )); buttonUpload->setEnabled(true); uploadInProgress = false; + saveRemoteUploadInfo(); return; } } @@ -483,6 +484,7 @@ job->showErrorDialog( this ); uploadInProgress = false; buttonUpload->setEnabled(true); + saveRemoteUploadInfo(); return; } KIO::FileCopyJob *fJob = dynamic_cast<KIO::FileCopyJob *>(job); @@ -555,8 +557,11 @@ // QListViewItem *it = list->findItem( currentURL.path() ); QListViewItem *it = currentItem; if (it) - { + { it->setSelected(false); + UploadTreeFile *itf = dynamic_cast<UploadTreeFile*>(it); + if (itf) + itf->setWhichPixmap( "check_clear" ); it->repaint(); } toUpload.remove( it );
You need to log in before you can comment on or make changes to this bug.