Bug 104790 – Do not indent forwarded articles -- formatting and text wrapping is not preserved!

First Last Prev Next No search results available Search page

Bug 104790:

Do not indent forwarded articles -- formatting ...

Product:	knode
Component:	general
Status:	RESOLVED
Resolution:	FIXED
Target:	---

Version:	unspecified
Priority:	NOR
Severity:	normal

Votes:

Description:
Opened: 2005-04-29 21:10 Last Changed: 2005-05-15 13:27:46

Version: (using KDE KDE 3.4.0) Installed from: SuSE RPMs When forwarding a newsgroup article via the "Forward by E-mail" command, KNode wraps the article in some helpful "---- Forwarded message -------" delimiters, but also indents the headers and body of the article. This is bad for at least two reasons: 1) Pushing all text over messes up word wrapping. 2) Altering the text of the message breaks embedded PGP signatures. Please instead format forwarded messages the same way that KMail does.

Comment #1 Volker Krause 2005-05-14 18:25:23

Very valid point, I'll fix this.

Comment #2 Volker Krause 2005-05-15 12:05:16

SVN commit 414096 by vkrause: Forward messages without indention or other whitespace changes, this breaks inline GPG signatures. CCBUG: 104790 M +9 -9 trunk/KDE/kdepim/knode/knarticlefactory.cpp --- trunk/KDE/kdepim/knode/knarticlefactory.cpp #414095:414096 @@ -307,22 +307,22 @@ //--------------------------- <Body> ----------------------------- - QString fwd=QString("\n,--------------- %1\n\n").arg(i18n("Forwarded message (begin)")); + QString fwd = QString("\n--------------- %1\n\n").arg(i18n("Forwarded message (begin)")); - fwd+=( i18n(" Subject")+": "+a->subject()->asUnicodeString()+"\n"); - fwd+=( i18n(" From")+": "+a->from()->asUnicodeString()+"\n"); - fwd+=( i18n(" Date")+": "+a->date()->asUnicodeString()+"\n"); - fwd+=( i18n(" Newsgroup")+": "+a->newsgroups()->asUnicodeString()+"\n\n"); + fwd+=( i18n("Subject") + ": " + a->subject()->asUnicodeString() + "\n" ); + fwd+=( i18n("From") + ": " + a->from()->asUnicodeString() + "\n" ); + fwd+=( i18n("Date") + ": " + a->date()->asUnicodeString() + "\n" ); + fwd+=( i18n("Newsgroup") + ": " + a->newsgroups()->asUnicodeString() + "\n\n" ); KMime::Content *text=a->textContent(); if(text) { QStringList decodedLines; - text->decodedText(decodedLines, true, knGlobals.configManager()->readNewsViewer()->removeTrailingNewlines()); + text->decodedText( decodedLines, false, false ); for(QStringList::Iterator it=decodedLines.begin(); it!=decodedLines.end(); ++it) - fwd+=" "+(*it)+"\n"; + fwd += (*it) + "\n"; } - fwd+=QString("\n`--------------- %1\n").arg(i18n("Forwarded message (end)")); + fwd += QString("\n--------------- %1\n").arg(i18n("Forwarded message (end)")); //--------------------------- </Body> ---------------------------- @@ -835,7 +835,7 @@ KMessageBox::sorry(knGlobals.topWidget, i18n("Please enter a valid email address at the identity tab of the account configuration dialog.")); else - KMessageBox::sorry(knGlobals.topWidget, + KMessageBox::sorry(knGlobals.topWidget, i18n("Please enter a valid email address at the identity section of the configuration dialog.")); delete art; return 0;

Comment #3 Volker Krause 2005-05-15 13:27:44

SVN commit 414118 by vkrause: Backport from trunk: Forward messages without indention or other whitespace changes, this breaks inline GPG signatures. BUG: 104790 M +9 -9 branches/KDE/3.4/kdepim/knode/knarticlefactory.cpp --- branches/KDE/3.4/kdepim/knode/knarticlefactory.cpp #414117:414118 @@ -307,22 +307,22 @@ //--------------------------- <Body> ----------------------------- - QString fwd=QString("\n,--------------- %1\n\n").arg(i18n("Forwarded message (begin)")); + QString fwd = QString("\n--------------- %1\n\n").arg(i18n("Forwarded message (begin)")); - fwd+=( i18n(" Subject")+": "+a->subject()->asUnicodeString()+"\n"); - fwd+=( i18n(" From")+": "+a->from()->asUnicodeString()+"\n"); - fwd+=( i18n(" Date")+": "+a->date()->asUnicodeString()+"\n"); - fwd+=( i18n(" Newsgroup")+": "+a->newsgroups()->asUnicodeString()+"\n\n"); + fwd+=( i18n("Subject") + ": " + a->subject()->asUnicodeString() + "\n" ); + fwd+=( i18n("From") + ": " + a->from()->asUnicodeString() + "\n" ); + fwd+=( i18n("Date") + ": " + a->date()->asUnicodeString() + "\n" ); + fwd+=( i18n("Newsgroup") + ": " + a->newsgroups()->asUnicodeString() + "\n\n" ); KMime::Content *text=a->textContent(); if(text) { QStringList decodedLines; - text->decodedText(decodedLines, true, knGlobals.configManager()->readNewsViewer()->removeTrailingNewlines()); + text->decodedText( decodedLines, false, false ); for(QStringList::Iterator it=decodedLines.begin(); it!=decodedLines.end(); ++it) - fwd+=" "+(*it)+"\n"; + fwd += (*it) + "\n"; } - fwd+=QString("\n`--------------- %1\n").arg(i18n("Forwarded message (end)")); + fwd += QString("\n--------------- %1\n").arg(i18n("Forwarded message (end)")); //--------------------------- </Body> ---------------------------- @@ -835,7 +835,7 @@ KMessageBox::sorry(knGlobals.topWidget, i18n("Please enter a valid email address at the identity tab of the account configuration dialog.")); else - KMessageBox::sorry(knGlobals.topWidget, + KMessageBox::sorry(knGlobals.topWidget, i18n("Please enter a valid email address at the identity section of the configuration dialog.")); delete art; return 0;

Platform:	SuSE RPMs
OS:	Linux
Keywords:

People

Reporter:	Tristan Miller
Assigned To:	Volker Krause

Related actions

Note

You need to log in before you can comment on or make changes to this bug.

Attachments
Add an attachment (proposed patch, testcase, etc.)

Depends on:
Blocks:
	Show dependency tree - Show dependency graph

First Last Prev Next No search results available Search page

Actions

Reports

My Account