| Bug 104422: Cannot talk to RFC977 servers (assumes availability of LIST OVERVIEW.FMT command) | (normal) |
| Opened: | 2005-04-23 13:18 |
| Product: | knode |
| Component: | general |
| Version: | unspecified |
| Status: | RESOLVED |
| Platform: | unspecified |
| Resolution: | FIXED |
| Reporter: | Ivan S. J. |
| Assigned to: | KNode Developers |
Version: 0.9.0 (using KDE 3.4.0 Level "b" , SUSE 9.3)
Compiler: gcc version 3.3.5 20050117 (prerelease) (SUSE Linux)
OS: Linux (x86_64) release 2.6.11.4-20a-smp
When fetching the article list knode assumes that the server understands "list overview.fmt" and handles errors badly:
C: GROUP something
S: 211 1139 2362 3500 something group selected
C: LIST OVERVIEW.FMT
S: 501 command syntax error
C: <stops, disconnects after some time>
If the server does not understand LIST OVERVIEW.FMT then Knode should assume the standard format and go ahead with XOVER or OVER.
------- Additional Comment #1 From Volker Krause 2005-05-28 18:34 -------
SVN commit 419141 by vkrause:
Check the response code after sending LIST OVERVIEW.FMT command. KNode
now works again with servers that don't support this command.
CCBUG: 104422, 106390
M +1 -1 knnntpclient.cpp
--- trunk/KDE/kdepim/knode/knnntpclient.cpp #419140:419141
at at -398,7 +398,7 at at
// see RFC 2980 section 2.1.7
QStrList headerformat;
cmd = "LIST OVERVIEW.FMT";
- if (sendCommand( cmd, rep )) {
+ if ( sendCommand( cmd, rep ) && rep == 215 ) {
QStrList tmp;
if (getMsg(tmp)) {
for(QCString s = tmp.first(); s; s = tmp.next()) {
------- Additional Comment #2 From Volker Krause 2005-05-28 18:36 -------
SVN commit 419143 by vkrause:
Backport from trunk for KDE 3.4.2:
Check the response code after sending LIST OVERVIEW.FMT command. KNode
now works again with servers that don't support this command.
BUG: 104422, 106390
M +1 -1 knnntpclient.cpp
--- branches/KDE/3.4/kdepim/knode/knnntpclient.cpp #419142:419143
at at -398,7 +398,7 at at
// see RFC 2980 section 2.1.7
QStrList headerformat;
cmd = "LIST OVERVIEW.FMT";
- if (sendCommand( cmd, rep )) {
+ if ( sendCommand( cmd, rep ) && rep == 215 ) {
QStrList tmp;
if (getMsg(tmp)) {
for(QCString s = tmp.first(); s; s = tmp.next()) {
| Attachment | Type | Modified | Status | Actions |
|---|---|---|---|---|
| Create a New Attachment (proposed patch, testcase, etc.) | View All | |||
Bugs.KDE.Org Actions