KDE Bug Tracking System
Home
Report New Wish or Bug
Query Existing Reports
First
Last
Prev
Next
No search results available
Search page
Bug
103278
:
Online Icons for not connected Protocols in Kop...
P
roduct
:
kopete
Co
m
ponent
:
general
Status
:
RESOLVED
Resolution
:
FIXED
Target
:
---
Version
:
0.10
Pr
i
ority
:
NOR
Severity
:
normal
V
otes
:
0
Description
:
Opened:
2005-04-05 12:19
Last Changed:
2005-04-07 13:15:12
Version: 0.10 (using KDE 3.4.0, Debian Package 4:3.4.0-0ubuntu3 (3.1)) Compiler: gcc version 3.3.5 (Debian 1:3.3.5-8ubuntu2) OS: Linux (i686) release 2.6.10-5-686 There is a new bug in the display of Kopete tray icons: Even for not connected protocols, the online icon is displayed in kopetes tray. This seems to be true for all protocols (aim, icq, irc, yahoo, yabber) except gadu. In the menu appearing when clicking on the protocol icons in the tray, the icons for setting the status to offline are also the online icons (all protocols except gadu). I checked /usr/share/apps/kopete/icons and the offline icons are in their place, too... cheers
Comment
#1
Will Stephenson 2005-04-05 12:40:47
Did you change the style for Disabled icons in the KDE advanced icon settings? The last person to report this bug had changed them so they appeared the same as Enabled icons.
Comment
#2
Daniel H Peger 2005-04-05 14:30:19
So what is the standard setting for disabled icons? I haven't changed this setting, and currently there is no effect set for disabled icons... But if this is the "bug", why does Gadu schow offline and online icons as it is supposed to do?
Comment
#3
Olivier Goffart 2005-04-05 14:33:02
To configure the disabled icon, go in kcontrol, icons, experimented, all icons, disabled, define effect. (--- now this is a message for the kopete theam ---) Anyway, i personally think we should not use the "disabled icons" for offline, but always use grayed icon. 1) i don't see how offline = disabled 2) if you use the transparency effect, that broke the drag and drop icon of offline contact 3) if you select an effect which is not different enough than normal you don't see the difference. I think that always gray the icon is probably the best solution. Anyway, the problem is that one can't see the diference between two different account colors. But i found no effect that render nicely which let see the account color, and which is different enough from online. anyway, 95% gray is probably a solution. Or maybe using a different overlay icon for offline (like gadu)
Comment
#4
Daniel H Peger 2005-04-05 14:44:38
Ok, setting the effect to grayed icons did the trick for me, but I agree with Olivier, not to use this standarized disabled effect... For reasons mentioned above. cheers
Comment
#5
Will Stephenson 2005-04-05 14:45:32
> Anyway, i personally think we should not use the "disabled icons" for > offline, but always use grayed icon.
Agreed - I don't like it any more either.
Comment
#6
Olivier Goffart 2005-04-06 10:17:30
CVS commit by ogoffart: Change the effect of the offline icons. Don't use anymore the disabled effect since it have nothing to do with offline. I used a 85% gray, so we still can see the account color. cf
http://lists.kde.org/?l=kopete-devel&m=111270440804913&w=2
BUG: 103278 M +4 -10 kopeteonlinestatusmanager.cpp 1.14 --- kdenetwork/kopete/libkopete/kopeteonlinestatusmanager.cpp #1.13:1.14 @@ -190,9 +190,10 @@ QPixmap* OnlineStatusManager::renderIcon *basis = KIconEffect().apply( *basis, KIconEffect::Colorize, 1, color, 0); - // Apply standard Disabled effect to generate account-offline icons // Note that we do this before compositing the overlay, since we want // that to be colored in this case. - if ( statusFor.internalStatus() == Kopete::OnlineStatus::AccountOffline ) - *basis = KIconEffect().apply( *basis, KIcon::Small, KIcon::DisabledState ); + if ( statusFor.internalStatus() == Kopete::OnlineStatus::AccountOffline || statusFor.status() == Kopete::OnlineStatus::Offline ) + { + *basis = KIconEffect().apply( *basis, KIconEffect::ToGray , 0.85, QColor() , false ); + } //composite the iconOverlay for this status and the supplied baseIcon @@ -219,11 +220,4 @@ QPixmap* OnlineStatusManager::renderIcon } - // Apply standard Disabled effect to generate Offline icons - // This will probably look crap on the Unknown icon - // FIXME This won't return icons that are not installed using Martijn's - // automake magic so we'd have to use UserIcon instead of SmallIcon - if ( statusFor.status() == OnlineStatus::Offline ) - *basis = KIconEffect().apply( *basis, KIcon::Small, KIcon::DisabledState ); - // no need to scale if the icon is already of the required size (assuming height == width!) if ( basis->width() != size )
Comment
#7
Olivier Goffart 2005-04-07 13:15:12
***
Bug 100747
has been marked as a duplicate of this bug. ***
P
latform
:
unspecified
O
S
:
Linux
K
eywords
:
U
RL
:
People
Reporter
:
Daniel H Peger
Assigned To
:
Kopete Developers
CC
:
shahamit gmail com
Related actions
View Bug Activity
Format For Printing
XML
Clone This Bug
Note
You need to
log in
before you can comment on or make changes to this bug.
Attachments
Add an attachment
(proposed patch, testcase, etc.)
Depends on
:
B
locks
:
Show dependency tree
-
Show dependency graph
First
Last
Prev
Next
No search results available
Search page
Actions
Reports
Requests
Reports
Bugs reported today
Bugs reported in the last 3 days
Bug reports with patches
Weekly Bug statistics
The most hated bugs
The most severe bugs
The most frequently reported bugs
The most wanted features
Junior Jobs
Report ownership counts and charts
My Account
New Account
Log In